Update MetadataFeature #1764
Merged
Update MetadataFeature #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
force-pushed
the
refactor-MetadataFeature
branch
3 times, most recently
from
c0e65dc to
5d92ece
Compare
|
Please review only sdk/src/types/block/output/feature/metadata.rs for now |
Why not keep it a draft then? 🤔 (You know we can also review that file if it's a draft |
)
Looks overall fine to me |
Alex6323
reviewed
Dec 19, 2023
Alex6323
reviewed
Dec 19, 2023
Alex6323
reviewed
Dec 19, 2023
Alex6323
reviewed
Dec 19, 2023
Alex6323
reviewed
Dec 19, 2023
Alex6323
reviewed
Dec 19, 2023
Alex6323
reviewed
Dec 22, 2023
Alex6323
reviewed
Jan 8, 2024
Alex6323
reviewed
Jan 8, 2024
Alex6323
previously approved these changes
Jan 9, 2024
Thoralf-M
force-pushed
the
refactor-MetadataFeature
branch
from
8daaf54 to
772f019
Compare
kwek20
reviewed
Jan 16, 2024
…e, fix rand_mana_allotment()
Merged
Some improvements to metadata feature
Alex6323
reviewed
Jan 17, 2024
Alex6323
reviewed
Jan 17, 2024
Alex6323
reviewed
Jan 17, 2024
Alex6323
reviewed
Jan 17, 2024
DaughterOfMars
approved these changes
Jan 17, 2024
thibault-martinez
approved these changes
Jan 17, 2024
Alex6323
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Refactor MetadataFeature to be compatible with https://github.com/iotaledger/tips/blob/tip38/tips/TIP-0038/tip-0038.md#metadata-feature
Links to any relevant issues
Closes #1693
Type of change
How the change has been tested
Running tests